Skip to content

chore: git pkg - removing logic for first commit#40004

Closed
brayn003 wants to merge 7 commits intoreleasefrom
chore/git-pkg-fixes-2
Closed

chore: git pkg - removing logic for first commit#40004
brayn003 wants to merge 7 commits intoreleasefrom
chore/git-pkg-fixes-2

Conversation

@brayn003
Copy link
Contributor

@brayn003 brayn003 commented Apr 1, 2025 •
edited by github-actions bot
Loading

Description

The implementation for first commit is buggy. It relies on lastDeployedAt key which is an application specific data point. For packages, the feature is broken and there is no easy solve for this. So, removing this for now, will revisit it in the future

Fixes #39498

Automation

/ok-to-test tags="@tag.Git"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14512902447
Commit: 766adf7
Cypress dashboard.
Tags: @tag.Git
Spec:
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
List of identified flaky tests.
Thu, 17 Apr 2025 10:44:56 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Streamlined the deployment interface by removing outdated metadata dependencies.
    • Updated commit message handling to consistently start as an empty string for a more straightforward experience.
  • Bug Fixes
    • Adjusted test specifications to ensure the commit button's visibility without executing the commit action.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 1, 2025 •
edited
Loading

Walkthrough

This pull request removes the properties lastDeployedAt and remoteUrl from the TabDeployViewProps interface in the TabDeployView.tsx file and simplifies the commit message initialization logic to always start with an empty string. In the index.tsx file, the changes eliminate the imports and logic related to Git context and metadata, resulting in fewer props passed to the TabDeployView component. Additionally, modifications in the test specification file adjust the handling of the commit operation.

Changes

File(s) Change Summary
app/client/src/git/.../TabDeployView.tsx Removed lastDeployedAt and remoteUrl from TabDeployViewProps; updated commit message state to initialize as an empty string unconditionally.
app/client/src/git/.../index.tsx Removed Git context and metadata imports and related variables (including extraction of lastDeployedAt and remoteUrl), reducing props passed to TabDeployView.
app/client/cypress/e2e/.../DSCrudAndBindings_Spec.ts Removed lines handling commit operation in tests, added assertion for commit button visibility instead.

Assessment against linked issues

Objective Addressed Explanation
[#39498] Commit message placeholder should not default to "First Commit" ✅

Possibly related PRs

  • chore: git mod - minor fixes #38563: The changes in the main PR are related to the removal of properties and logic that affect the TabDeployView component, which is also impacted by the modifications in the retrieved PR that involve the removal of similar properties and logic related to module instances and source modules. Thus, both PRs address related aspects of the Git context and metadata handling.

Suggested labels

Bug, Critical, Release Blocker, Git Product

Suggested reviewers

  • ashit-rath
  • sagar-qa007

Poem

Code trims down with a gentle stream,
Old props vanish like a fading dream.
Simplicity reigns in each new line,
Deployment now looks truly fine.
Cheers to clean code and a bright design!

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 0b64c18 and 7830341.

📒 Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Packages & Git Pod All issues belonging to Packages and Git Packages Product Issues related to packages Release labels Apr 1, 2025
@brayn003 brayn003 changed the title chore: removing logic for first commit chore: git pkg - removing logic for first commit Apr 1, 2025
@brayn003 brayn003 self-assigned this Apr 1, 2025
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Bug Something isn't working and removed Bug Something isn't working labels Apr 1, 2025
@brayn003 brayn003 added the ok-to-test Required label for CI label Apr 1, 2025
@github-actions github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels Apr 1, 2025
@brayn003 brayn003 requested a review from ApekshaBhosale as a code owner April 1, 2025 11:26
@github-actions github-actions bot added the Bug Something isn't working label Apr 1, 2025
@brayn003 brayn003 removed the request for review from ApekshaBhosale April 1, 2025 11:27
@github-actions github-actions bot removed the Bug Something isn't working label Apr 1, 2025
@github-actions github-actions bot added the Bug Something isn't working label Apr 1, 2025
@github-actions
Copy link

github-actions bot commented Apr 10, 2025

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Apr 10, 2025
@brayn003 brayn003 removed the ok-to-test Required label for CI label Apr 17, 2025
@brayn003 brayn003 added the ok-to-test Required label for CI label Apr 17, 2025
@github-actions
Copy link

github-actions bot commented Apr 24, 2025

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brayn003 brayn003

Labels

Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Packages & Git Pod All issues belonging to Packages and Git Packages Product Issues related to packages Release skip-changelog Adding this label to a PR prevents it from being listed in the changelog Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: [Git With Packages] for every commit, the placeholder is coming as First Commit

1 participant

@brayn003